From a52de998136e11e89b388e143125c402d6cdfe3e Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Fri, 30 Jul 2021 16:08:03 +0100 Subject: [PATCH] trivial: Do not assume updates fail by default We have the property notification in place now so that the update state is saved correctly to the database on error. This helps with debugging as we don't need to explain (to ourselves?!) why the device is marked as failed even though nothing has run. --- src/fu-engine.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/fu-engine.c b/src/fu-engine.c index 655da4c1e..4a1b5dc5e 100644 --- a/src/fu-engine.c +++ b/src/fu-engine.c @@ -2439,7 +2439,6 @@ fu_engine_install_release (FuEngine *self, if (tmp != NULL) fwupd_release_add_checksum (release_tmp, tmp); fwupd_release_set_version (release_tmp, version_rel); - fu_device_set_update_state (device, FWUPD_UPDATE_STATE_FAILED); if (!fu_history_add_device (self->history, device, release_tmp, error)) return FALSE; }