From a4e0de462c70efb2a04ebba5bfb2d16d3ea8835e Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Sun, 14 Feb 2021 20:33:47 +0000 Subject: [PATCH] trivial: Fix AddressSanitizer heap-buffer-overflow --- libfwupdplugin/fu-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libfwupdplugin/fu-common.c b/libfwupdplugin/fu-common.c index b21168d52..707ee1503 100644 --- a/libfwupdplugin/fu-common.c +++ b/libfwupdplugin/fu-common.c @@ -1896,7 +1896,7 @@ fu_common_strsafe (const gchar *str, gsize maxsz) /* replace non-printable chars with '.' */ tmp = g_string_sized_new (maxsz); - for (gsize i = 0; str[i] != '\0' && i < maxsz; i++) { + for (gsize i = 0; i < maxsz && str[i] != '\0'; i++) { if (!g_ascii_isprint (str[i])) { g_string_append_c (tmp, '.'); continue;