proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-27 09:46:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

redfish: Don't add the backup BMC device as it shares the same GUIDs

Browse Source 
This fixes the problem when the UEFI update depends on a specific BMC
version -- including the backup BMC device means we checking that both
the primary and the backup were above a specific version.

I don't think it's ever useful to show the backup BMC device, so just
don't include it as an enumerated device.

Fixes https://github.com/fwupd/fwupd/issues/4404
This commit is contained in:
Richard Hughes 2022-03-17 13:13:35 +00:00
parent 41bc319331
commit a11fefff35
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/redfish/fu-redfish-backend.c
View File

@ -92,6 +92,7 @@ fu_redfish_backend_coldplug_member(FuRedfishBackend *self, JsonObject *member, G
{ {
g_autoptr(FuDevice) dev = NULL; g_autoptr(FuDevice) dev = NULL;
g_autoptr(FuDeviceLocker) locker = NULL; g_autoptr(FuDeviceLocker) locker = NULL;
g_autoptr(GError) error_local = NULL;
/* create of the correct type */ /* create of the correct type */
dev = g_object_new(self->device_gtype, dev = g_object_new(self->device_gtype,
@ -108,9 +109,15 @@ fu_redfish_backend_coldplug_member(FuRedfishBackend *self, JsonObject *member, G
fu_device_add_private_flag(dev, FU_REDFISH_DEVICE_FLAG_WILDCARD_TARGETS); fu_device_add_private_flag(dev, FU_REDFISH_DEVICE_FLAG_WILDCARD_TARGETS);
/* probe + setup */ /* probe + setup */
locker = fu_device_locker_new(dev, error); locker = fu_device_locker_new(dev, &error_local);
if (locker == NULL) if (locker == NULL) {
if (g_error_matches(error_local, FWUPD_ERROR, FWUPD_ERROR_NOT_SUPPORTED)) {
g_debug("failed to setup: %s", error_local->message);
return TRUE;
}
g_propagate_error(error, g_steal_pointer(&error_local));
return FALSE; return FALSE;
}
if (self->max_image_size != 0) if (self->max_image_size != 0)
fu_device_set_firmware_size_max(dev, (guint64)self->max_image_size); fu_device_set_firmware_size_max(dev, (guint64)self->max_image_size);
fu_backend_device_added(FU_BACKEND(self), dev); fu_backend_device_added(FU_BACKEND(self), dev);

2
plugins/redfish/redfish.quirk
View File

@ -4,7 +4,7 @@ Flags = wildcard-targets,reset-required
[REDFISH\VENDOR_Lenovo&ID_BMC-Backup] [REDFISH\VENDOR_Lenovo&ID_BMC-Backup]
ParentGuid = REDFISH\VENDOR_Lenovo&ID_BMC-Primary ParentGuid = REDFISH\VENDOR_Lenovo&ID_BMC-Primary
Flags = dual-image,is-backup Flags = dual-image,is-backup,no-probe
[REDFISH\VENDOR_Lenovo&ID_BMC-Primary] [REDFISH\VENDOR_Lenovo&ID_BMC-Primary]
ParentGuid = REDFISH\VENDOR_Lenovo&ID_BMC-Primary ParentGuid = REDFISH\VENDOR_Lenovo&ID_BMC-Primary