proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-13 21:09:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vli: Fix a regression when installing VL820Q7 firmware

Browse Source 
This regressed in c255034574 which caused
ThinkPad Thunderbolt 3 Workstation Dock updates to fail.

Fixes https://github.com/fwupd/fwupd/issues/3460
This commit is contained in:
Richard Hughes 2021-07-16 16:37:51 +01:00
parent 3dfae9dc1b
commit a0fd32f418
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/vli/fu-vli-usbhub-firmware.c
View File

@ -182,15 +182,8 @@ fu_vli_usbhub_firmware_parse (FuFirmware *firmware,
if (tmp == 0xF0) {
self->device_kind = FU_VLI_DEVICE_KIND_VL822;
} else {
/* Q7/Q8 requires searching two addresses for offset value */
if (!fu_common_read_uint16_safe (buf, bufsz, 0x8018,
&adr_ofs,G_BIG_ENDIAN, error)) {
g_prefix_error (error, "failed to get Q7/Q8 offset mapping: ");
return FALSE;
}
if (!fu_common_read_uint8_safe (buf, bufsz, adr_ofs + 0x2000 + 0x05,
&tmp, error)) {
g_prefix_error (error, "failed to get offset version: ");
if (!fu_common_read_uint8_safe (buf, bufsz, 0xf000, &tmp, error)) {
g_prefix_error (error, "failed to get Q7/Q8 difference: ");
return FALSE;
}
if (tmp & (1 << 0))