proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-10 04:12:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dfu: Allow quirking the target transfer size

Browse Source
This commit is contained in:
Richard Hughes 2021-01-20 15:09:02 +00:00
parent 89ee9edc0a
commit 8ca69364af
2 changed files with 26 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
plugins/dfu/README.md
View File

@ -41,6 +41,7 @@ This plugin uses the following plugin-specific quirks:
|`DfuFlags` | Optional quirks for a DFU device which doesn't follow the DFU 1.0 or 1.1 specification | 1.0.1| |`DfuFlags` | Optional quirks for a DFU device which doesn't follow the DFU 1.0 or 1.1 specification | 1.0.1|
|`DfuForceVersion` | Forces a specific DFU version for the hardware device. This is required if the device does not set, or sets incorrectly, items in the DFU functional descriptor. |1.0.1| |`DfuForceVersion` | Forces a specific DFU version for the hardware device. This is required if the device does not set, or sets incorrectly, items in the DFU functional descriptor. |1.0.1|
|`DfuForceTimeout` | Forces a specific device timeout, in ms | 1.4.0 | |`DfuForceTimeout` | Forces a specific device timeout, in ms | 1.4.0 |
|`DfuForceTransferSize` | Forces a target transfer size, in bytes | 1.5.6 |
External interface access External interface access
------------------------- -------------------------

30
plugins/dfu/dfu-device.c
View File

@ -95,6 +95,7 @@ typedef struct {
gchar *chip_id; gchar *chip_id;
guint16 version; guint16 version;
guint16 force_version; guint16 force_version;
guint16 force_transfer_size;
guint16 runtime_pid; guint16 runtime_pid;
guint16 runtime_vid; guint16 runtime_vid;
guint16 runtime_release; guint16 runtime_release;
@ -122,6 +123,10 @@ dfu_device_to_string (FuDevice *device, guint idt, GString *str)
fu_common_string_append_kv (str, idt, "ChipId", priv->chip_id); fu_common_string_append_kv (str, idt, "ChipId", priv->chip_id);
fu_common_string_append_kx (str, idt, "Version", priv->version); fu_common_string_append_kx (str, idt, "Version", priv->version);
fu_common_string_append_kx (str, idt, "ForceVersion", priv->force_version); fu_common_string_append_kx (str, idt, "ForceVersion", priv->force_version);
if (priv->force_transfer_size != 0x0) {
fu_common_string_append_kx (str, idt, "ForceTransferSize",
priv->force_transfer_size);
}
fu_common_string_append_kx (str, idt, "RuntimePid", priv->runtime_pid); fu_common_string_append_kx (str, idt, "RuntimePid", priv->runtime_pid);
fu_common_string_append_kx (str, idt, "RuntimeVid", priv->runtime_vid); fu_common_string_append_kx (str, idt, "RuntimeVid", priv->runtime_vid);
fu_common_string_append_kx (str, idt, "RuntimeRelease", priv->runtime_release); fu_common_string_append_kx (str, idt, "RuntimeRelease", priv->runtime_release);
@ -345,15 +350,18 @@ dfu_device_add_targets (DfuDevice *device, GError **error)
} }
/* fix up the transfer size */ /* fix up the transfer size */
if (priv->transfer_size == 0xffff) { if (priv->force_transfer_size != 0x0) {
priv->transfer_size = priv->force_transfer_size;
g_debug ("forcing DFU transfer size 0x%04x bytes", priv->transfer_size);
} else if (priv->transfer_size == 0xffff) {
priv->transfer_size = 0x0400; priv->transfer_size = 0x0400;
g_debug ("DFU transfer size unspecified, guessing"); g_debug ("DFU transfer size unspecified, guessing");
} } else if (priv->transfer_size == 0x0) {
if (priv->transfer_size > 0x0000) {
g_debug ("using DFU transfer size 0x%04x bytes", priv->transfer_size);
} else {
g_warning ("DFU transfer size invalid, using default"); g_warning ("DFU transfer size invalid, using default");
priv->transfer_size = 64; priv->transfer_size = 64;
} else {
g_debug ("using DFU transfer size 0x%04x bytes",
priv->transfer_size);
} }
/* create a target of the required type */ /* create a target of the required type */
@ -1782,6 +1790,18 @@ dfu_device_set_quirk_kv (FuDevice *device,
"invalid DFU timeout"); "invalid DFU timeout");
return FALSE; return FALSE;
} }
if (g_strcmp0 (key, "DfuForceTransferSize") == 0) {
guint64 tmp = fu_common_strtoull (value);
if (tmp < G_MAXUINT16) {
priv->force_transfer_size = tmp;
return TRUE;
}
g_set_error_literal (error,
G_IO_ERROR,
G_IO_ERROR_INVALID_DATA,
"invalid DFU transfer size");
return FALSE;
}
/* failed */ /* failed */
g_set_error_literal (error, g_set_error_literal (error,