proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-08 10:27:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

genesys: scaler: Fix calling to parent's vfunc close()

Browse Source 
This uses the internal flag FU_DEVICE_INTERNAL_FLAG_USE_PARENT_FOR_OPEN,
to fix the calling to the parent's vfunc close() (it was calling the
parent's vfunc open() on close()).
This commit is contained in:
Gaël PORTAY 2022-06-02 15:06:20 +02:00 committed by Gaël PORTAY
parent d5b7206a3a
commit 88db2a3f9e
1 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
plugins/genesys/fu-genesys-scaler-device.c
View File

@ -1621,22 +1621,6 @@ fu_genesys_scaler_device_probe(FuDevice *device, GError **error)
return TRUE; return TRUE;
} }
static gboolean
fu_genesys_scaler_device_open(FuDevice *device, GError **error)
{
FuDevice *parent_device = fu_device_get_parent(device);
return fu_device_open(parent_device, error);
}
static gboolean
fu_genesys_scaler_device_close(FuDevice *device, GError **error)
{
FuDevice *parent_device = fu_device_get_parent(device);
return fu_device_open(parent_device, error);
}
static gboolean static gboolean
fu_genesys_scaler_device_setup(FuDevice *device, GError **error) fu_genesys_scaler_device_setup(FuDevice *device, GError **error)
{ {
@ -1957,6 +1941,7 @@ fu_genesys_scaler_device_init(FuGenesysScalerDevice *self)
fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_DUAL_IMAGE); fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_DUAL_IMAGE);
fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_UNSIGNED_PAYLOAD); fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_UNSIGNED_PAYLOAD);
fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_CAN_VERIFY_IMAGE); fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_CAN_VERIFY_IMAGE);
fu_device_add_internal_flag(FU_DEVICE(self), FU_DEVICE_INTERNAL_FLAG_USE_PARENT_FOR_OPEN);
fu_device_register_private_flag(FU_DEVICE(self), fu_device_register_private_flag(FU_DEVICE(self),
FU_SCALER_FLAG_PAUSE_R2_CPU, FU_SCALER_FLAG_PAUSE_R2_CPU,
"pause-r2-cpu"); "pause-r2-cpu");
@ -1974,8 +1959,6 @@ fu_genesys_scaler_device_class_init(FuGenesysScalerDeviceClass *klass)
{ {
FuDeviceClass *klass_device = FU_DEVICE_CLASS(klass); FuDeviceClass *klass_device = FU_DEVICE_CLASS(klass);
klass_device->probe = fu_genesys_scaler_device_probe; klass_device->probe = fu_genesys_scaler_device_probe;
klass_device->open = fu_genesys_scaler_device_open;
klass_device->close = fu_genesys_scaler_device_close;
klass_device->setup = fu_genesys_scaler_device_setup; klass_device->setup = fu_genesys_scaler_device_setup;
klass_device->dump_firmware = fu_genesys_scaler_device_dump_firmware; klass_device->dump_firmware = fu_genesys_scaler_device_dump_firmware;
klass_device->prepare_firmware = fu_genesys_scaler_device_prepare_firmware; klass_device->prepare_firmware = fu_genesys_scaler_device_prepare_firmware;