proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-05 19:48:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: Fix getting details about firmware for unknown devices

Browse Source 
Fix a logic error when testing requirements; what was supposed to happen was
that a the firmware requirements were only processed when we had a FuDevice set
in the FuInstallTask, but instead we were falling through to the handler for
'unknown requirement type'.
This commit is contained in:
Richard Hughes 2018-08-06 11:03:06 +01:00
parent 38c7c334f4
commit 881f624eba
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/fu-engine.c
View File

@ -897,8 +897,11 @@ fu_engine_check_requirement (FuEngine *self, AsRequire *req, FuDevice *device, G
return fu_engine_check_requirement_id (self, req, error);
/* ensure firmware requirement */
if (device != NULL && as_require_get_kind (req) == AS_REQUIRE_KIND_FIRMWARE)
if (as_require_get_kind (req) == AS_REQUIRE_KIND_FIRMWARE) {
if (device == NULL)
return TRUE;
return fu_engine_check_requirement_firmware (self, req, device, error);
}
/* ensure hardware requirement */
if (as_require_get_kind (req) == AS_REQUIRE_KIND_HARDWARE)