From 87ffda474b12c324e111473dd593b77fc9b0cab8 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Tue, 13 Dec 2022 09:28:56 +0000 Subject: [PATCH] Allow getting the ESP when there is a block device with no filesystem Fixes https://github.com/fwupd/fwupd/issues/5313 --- libfwupdplugin/fu-volume.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libfwupdplugin/fu-volume.c b/libfwupdplugin/fu-volume.c index 810f9aad8..86125cc24 100644 --- a/libfwupdplugin/fu-volume.c +++ b/libfwupdplugin/fu-volume.c @@ -516,6 +516,7 @@ fu_volume_new_by_kind(const gchar *kind, GError **error) g_autoptr(FuVolume) vol = NULL; g_autoptr(GDBusProxy) proxy_part = NULL; g_autoptr(GDBusProxy) proxy_fs = NULL; + g_autoptr(GError) error_proxy_fs = NULL; g_autoptr(GVariant) val = NULL; proxy_part = g_dbus_proxy_new_sync(g_dbus_proxy_get_connection(proxy_blk), @@ -544,12 +545,12 @@ fu_volume_new_by_kind(const gchar *kind, GError **error) g_dbus_proxy_get_object_path(proxy_blk), UDISKS_DBUS_INTERFACE_FILESYSTEM, NULL, - error); + &error_proxy_fs); if (proxy_fs == NULL) { - g_prefix_error(error, - "failed to initialize d-bus proxy %s: ", - g_dbus_proxy_get_object_path(proxy_blk)); - return NULL; + g_debug("failed to get filesystem for %s: %s", + g_dbus_proxy_get_object_path(proxy_blk), + error_proxy_fs->message); + continue; } vol = g_object_new(FU_TYPE_VOLUME, "proxy-block",