From 817a15a1bfa3e9a5399b9f11d5825c844f3671bd Mon Sep 17 00:00:00 2001 From: Mario Limonciello Date: Mon, 26 Nov 2018 14:07:50 -0600 Subject: [PATCH] trivial: dell-dock: Set EC version to daemon before EC reset If the process fails (or was skipped due to 'skip-restart') this will prevent the daemon from trying again until the dock has been power cycled. --- plugins/dell-dock/fu-dell-dock-i2c-ec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/dell-dock/fu-dell-dock-i2c-ec.c b/plugins/dell-dock/fu-dell-dock-i2c-ec.c index 4c6b506b7..893e8e017 100644 --- a/plugins/dell-dock/fu-dell-dock-i2c-ec.c +++ b/plugins/dell-dock/fu-dell-dock-i2c-ec.c @@ -688,6 +688,9 @@ fu_dell_dock_ec_write_fw (FuDevice *device, GBytes *blob_fw, if (!fu_dell_dock_hid_raise_mcu_clock (self->symbiote, FALSE, error)) return FALSE; + /* dock will reboot to re-read; this is to appease the daemon */ + fu_device_set_version (device, dynamic_version); + if (fu_device_has_custom_flag (device, "skip-restart")) { g_debug ("Skipping EC reset per quirk request"); return TRUE; @@ -733,9 +736,6 @@ fu_dell_dock_ec_write_fw (FuDevice *device, GBytes *blob_fw, } } - /* dock will reboot to re-read; this is to appease the daemon */ - fu_device_set_version (device, dynamic_version); - return TRUE; }