proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-14 00:48:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

wacom-usb: Legacy Bluetooth module reports version numbers in little-endian

Browse Source 
While the modern firmware interfaces report their version numbers in
big-endian form, reading the legacy Bluetooth module version via the
FU_WAC_REPORT_ID_GET_FIRMWARE_VERSION_BLUETOOTH report requires us to
actually parse a little-endian value. This difference was overlooked
when making changes to the version parsing code in commit 50a4ec70e6.
This commit restores the proper interpretation.

Fixes: 50a4ec70e6 (wacom_usb: Firmware versions are packed BCD, not "decimal")
This commit is contained in:
Jason Gerecke 2021-06-17 09:02:01 -07:00 committed by Richard Hughes
parent 9f13d8ed1e
commit 81482c3ba7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/wacom-usb/fu-wac-device.c
View File

@ -654,7 +654,7 @@ fu_wac_device_add_modules_bluetooth (FuWacDevice *self, GError **error)
}
if (!fu_common_read_uint16_safe (buf, sizeof(buf), 1, &fw_ver,
G_BIG_ENDIAN, error))
G_LITTLE_ENDIAN, error))
return FALSE;
version = fu_common_version_from_uint16 (fw_ver, FWUPD_VERSION_FORMAT_BCD);