proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-05 19:48:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Record an error if any NEEDS_REBOOT transaction fails to be applied

Browse Source 
In the case of failing to even set up UpdateCapsule, the uefi plugin would
dutifully return SUCCESS as it was referring to the 2nd-to-last update that
actually worked.
This commit is contained in:
Richard Hughes 2018-01-12 16:50:05 +00:00
parent 7984310a65
commit 7e070c9bd7
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/fu-engine.c
View File

@ -3368,23 +3368,28 @@ fu_engine_update_history_device (FuEngine *self, FuDevice *dev_history, GError *
return TRUE;
}
/* find the plugin that started the update */
/* does the plugin know the update failure */
plugin = fu_plugin_list_find_by_name (self->plugin_list,
fu_device_get_plugin (dev),
error);
if (plugin == NULL)
return FALSE;
/* the plugin knows the update state */
if (!fu_plugin_runner_get_results (plugin, dev, error))
return FALSE;
if (fu_device_get_update_state (dev) != FWUPD_UPDATE_STATE_NEEDS_REBOOT) {
if (!fu_history_set_device_error (self->history,
fu_device_get_id (dev),
fu_device_get_update_error (dev),
error))
return FALSE;
/* the plugin either can't tell us the error, or doesn't know itself */
if (fu_device_get_update_state (dev) != FWUPD_UPDATE_STATE_FAILED) {
g_debug ("falling back to generic failure");
fu_device_set_update_error (dev, "failed to run update on reboot");
}
/* update the state in the database */
if (!fu_history_set_device_error (self->history, fu_device_get_id (dev),
fu_device_get_update_error (dev),
error))
return FALSE;
/* success */
return TRUE;
}