proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-27 09:46:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Ensure composite devices all share the same acquiesce delay

Browse Source 
We go to great pains to set the parent to the MAX of the child delays, but we
don't actually set the children to have the new parent value.

This means if you update the child device without the parent in the transaction
we don't always wait for all the USB devices to come back -- which is what the
acquiesce delay is designed to do.

Fixes an intermittant device test for the Wacom USB tablet.
This commit is contained in:
Richard Hughes 2023-02-09 12:40:05 +00:00
parent fa72578666
commit 7c10fb0e12
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libfwupdplugin/fu-device.c
View File

@ -1378,6 +1378,12 @@ fu_device_add_child(FuDevice *self, FuDevice *child)
}
}
/* ensure child has the parent acquiesce delay */
for (guint i = 0; i < children->len; i++) {
FuDevice *child_tmp = g_ptr_array_index(children, i);
fu_device_set_acquiesce_delay(child_tmp, priv->acquiesce_delay);
}
/* copy from main device if unset */
if (fu_device_get_physical_id(child) == NULL && fu_device_get_physical_id(self) != NULL)
fu_device_set_physical_id(child, fu_device_get_physical_id(self));