proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-08 07:22:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: Improve the debugging output for FU_HID_DEVICE_VERBOSE

Browse Source
This commit is contained in:
Richard Hughes 2020-11-06 19:26:46 +00:00
parent a01fdde628
commit 7bb9b1f6e8
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
libfwupdplugin/fu-hid-device.c
View File

@ -233,7 +233,10 @@ fu_hid_device_set_report_internal (FuHidDevice *self,
wvalue = (FU_HID_REPORT_TYPE_FEATURE << 8) | helper->value; wvalue = (FU_HID_REPORT_TYPE_FEATURE << 8) | helper->value;
if (g_getenv ("FU_HID_DEVICE_VERBOSE") != NULL) { if (g_getenv ("FU_HID_DEVICE_VERBOSE") != NULL) {
fu_common_dump_raw (G_LOG_DOMAIN, "HID::SetReport", g_autofree gchar *title = NULL;
title = g_strdup_printf ("HID::SetReport [wValue=0x%04x ,wIndex=%u]",
wvalue, priv->interface);
fu_common_dump_raw (G_LOG_DOMAIN, title,
helper->buf, helper->bufsz); helper->buf, helper->bufsz);
} }
usb_device = fu_usb_device_get_dev (FU_USB_DEVICE (self)); usb_device = fu_usb_device_get_dev (FU_USB_DEVICE (self));
@ -334,7 +337,10 @@ fu_hid_device_get_report_internal (FuHidDevice *self,
wvalue = (FU_HID_REPORT_TYPE_FEATURE << 8) | helper->value; wvalue = (FU_HID_REPORT_TYPE_FEATURE << 8) | helper->value;
if (g_getenv ("FU_HID_DEVICE_VERBOSE") != NULL) { if (g_getenv ("FU_HID_DEVICE_VERBOSE") != NULL) {
fu_common_dump_raw (G_LOG_DOMAIN, "HID::GetReport", g_autofree gchar *title = NULL;
title = g_strdup_printf ("HID::GetReport [wValue=0x%04x, wIndex=%u]",
wvalue, priv->interface);
fu_common_dump_raw (G_LOG_DOMAIN, title,
helper->buf, actual_len); helper->buf, actual_len);
} }
usb_device = fu_usb_device_get_dev (FU_USB_DEVICE (self)); usb_device = fu_usb_device_get_dev (FU_USB_DEVICE (self));
@ -351,8 +357,12 @@ fu_hid_device_get_report_internal (FuHidDevice *self,
g_prefix_error (error, "failed to GetReport: "); g_prefix_error (error, "failed to GetReport: ");
return FALSE; return FALSE;
} }
if (g_getenv ("FU_HID_DEVICE_VERBOSE") != NULL) if (g_getenv ("FU_HID_DEVICE_VERBOSE") != NULL) {
fu_common_dump_raw (G_LOG_DOMAIN, "HID::GetReport", helper->buf, actual_len); g_autofree gchar *title = NULL;
title = g_strdup_printf ("HID::GetReport [wValue=0x%04x, wIndex=%u]",
wvalue, priv->interface);
fu_common_dump_raw (G_LOG_DOMAIN, title, helper->buf, actual_len);
}
if ((helper->flags & FU_HID_DEVICE_FLAG_ALLOW_TRUNC) == 0 && actual_len != helper->bufsz) { if ((helper->flags & FU_HID_DEVICE_FLAG_ALLOW_TRUNC) == 0 && actual_len != helper->bufsz) {
g_set_error (error, G_IO_ERROR, G_IO_ERROR_INVALID_DATA, g_set_error (error, G_IO_ERROR, G_IO_ERROR_INVALID_DATA,
"read %" G_GSIZE_FORMAT ", requested %" G_GSIZE_FORMAT " bytes", "read %" G_GSIZE_FORMAT ", requested %" G_GSIZE_FORMAT " bytes",