From 5f7450466771fc545e40d8eee613f3e8b8a08b5a Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Tue, 8 Jun 2021 14:19:31 +0100 Subject: [PATCH] vli: Fix the i2c device enumeration, e.g. MSP430 This regressed in f9e9e087d, as we're using FuDevice->setup() to check if the device is present, but without setting the physical IDs. --- plugins/vli/fu-vli-usbhub-msp430-device.c | 1 + plugins/vli/fu-vli-usbhub-rtd21xx-device.c | 1 + 2 files changed, 2 insertions(+) diff --git a/plugins/vli/fu-vli-usbhub-msp430-device.c b/plugins/vli/fu-vli-usbhub-msp430-device.c index 47f4e2a69..89b317fb2 100644 --- a/plugins/vli/fu-vli-usbhub-msp430-device.c +++ b/plugins/vli/fu-vli-usbhub-msp430-device.c @@ -308,6 +308,7 @@ fu_vli_usbhub_msp430_device_probe (FuDevice *device, GError **error) g_autofree gchar *instance_id = NULL; fu_device_set_name (device, fu_vli_common_device_kind_to_string (device_kind)); + fu_device_set_physical_id (device, fu_device_get_physical_id (FU_DEVICE (parent))); /* add instance ID */ instance_id = g_strdup_printf ("USB\\VID_%04X&PID_%04X&I2C_%s", diff --git a/plugins/vli/fu-vli-usbhub-rtd21xx-device.c b/plugins/vli/fu-vli-usbhub-rtd21xx-device.c index 57e3b1e57..5d197782a 100644 --- a/plugins/vli/fu-vli-usbhub-rtd21xx-device.c +++ b/plugins/vli/fu-vli-usbhub-rtd21xx-device.c @@ -480,6 +480,7 @@ fu_vli_usbhub_rtd21xx_device_probe (FuDevice *device, GError **error) g_autofree gchar *instance_id = NULL; fu_device_set_name (device, fu_vli_common_device_kind_to_string (device_kind)); + fu_device_set_physical_id (device, fu_device_get_physical_id (FU_DEVICE (parent))); /* add instance ID */ instance_id = g_strdup_printf ("USB\\VID_%04X&PID_%04X&I2C_%s",