proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-15 13:55:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

uefi-dbx: Fix a critical warning when parsing invalid firmware

Browse Source
This commit is contained in:
Richard Hughes 2021-01-05 13:19:43 +00:00
parent 09f8a549c9
commit 59b6b6d2c5
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/uefi-dbx/fu-efi-signature-list.c
View File

@ -28,12 +28,24 @@ fu_efi_signature_list_parse_item (FuEfiSignatureList *self,
GError **error) GError **error)
{ {
fwupd_guid_t guid; fwupd_guid_t guid;
gsize sig_datasz = sig_size - sizeof(fwupd_guid_t); gsize sig_datasz;
g_autofree gchar *sig_owner = NULL; g_autofree gchar *sig_owner = NULL;
g_autofree guint8 *sig_data = g_malloc0 (sig_datasz); g_autofree guint8 *sig_data = NULL;
g_autoptr(FuEfiSignature) sig = NULL; g_autoptr(FuEfiSignature) sig = NULL;
g_autoptr(GBytes) data = NULL; g_autoptr(GBytes) data = NULL;
/* allocate data buf */
if (sig_size <= sizeof(fwupd_guid_t)) {
g_set_error (error,
G_IO_ERROR,
G_IO_ERROR_FAILED,
"SignatureSize invalid: 0x%x",
(guint) sig_size);
return FALSE;
}
sig_datasz = sig_size - sizeof(fwupd_guid_t);
sig_data = g_malloc0 (sig_datasz);
/* read both blocks of data */ /* read both blocks of data */
if (!fu_memcpy_safe ((guint8 *) &guid, sizeof(guid), 0x0, /* dst */ if (!fu_memcpy_safe ((guint8 *) &guid, sizeof(guid), 0x0, /* dst */
buf, bufsz, offset, /* src */ buf, bufsz, offset, /* src */