proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-07 08:39:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

elantp: Write the firmware in a slightly safer way

Browse Source
This commit is contained in:
Richard Hughes 2021-03-05 09:47:38 +00:00
parent dd5f6247bc
commit 56af6f21e9
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
plugins/elantp/fu-elantp-firmware.c
View File

@ -154,12 +154,21 @@ fu_elantp_firmware_write (FuFirmware *firmware, GError **error)
* ------ * ------
*/ */
fu_byte_array_set_size (buf, self->iap_addr + 0x2 + 0x2); fu_byte_array_set_size (buf, self->iap_addr + 0x2 + 0x2);
fu_common_write_uint16 (buf->data + ETP_IAP_START_ADDR_WRDS * 2, if (!fu_common_write_uint16_safe (buf->data, buf->len,
self->iap_addr / 2, G_LITTLE_ENDIAN); ETP_IAP_START_ADDR_WRDS * 2,
fu_common_write_uint16 (buf->data + self->iap_addr, self->iap_addr / 2,
(self->iap_addr + 2) / 2, G_LITTLE_ENDIAN); G_LITTLE_ENDIAN, error))
fu_common_write_uint16 (buf->data + self->iap_addr + 0x2, return NULL;
self->module_id, G_LITTLE_ENDIAN); if (!fu_common_write_uint16_safe (buf->data, buf->len,
self->iap_addr,
(self->iap_addr + 2) / 2,
G_LITTLE_ENDIAN, error))
return NULL;
if (!fu_common_write_uint16_safe (buf->data, buf->len,
self->iap_addr + 0x2,
self->module_id,
G_LITTLE_ENDIAN, error))
return NULL;
g_byte_array_append (buf, g_bytes_get_data (blob, NULL), g_bytes_get_size (blob)); g_byte_array_append (buf, g_bytes_get_data (blob, NULL), g_bytes_get_size (blob));
g_byte_array_append (buf, elantp_signature, sizeof(elantp_signature)); g_byte_array_append (buf, elantp_signature, sizeof(elantp_signature));
return g_byte_array_free_to_bytes (g_steal_pointer (&buf)); return g_byte_array_free_to_bytes (g_steal_pointer (&buf));