proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-07 01:08:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libfwupd: Fix a tiny memory leak when using fwupd_client_connect()

Browse Source
This commit is contained in:
Richard Hughes 2021-01-08 14:48:35 +00:00
parent fb36f226ed
commit 5511dbccf0
1 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
libfwupd/fwupd-client.c
View File

@ -451,6 +451,10 @@ fwupd_client_connect_get_proxy_cb (GObject *source,
g_autoptr(GVariant) val = NULL; g_autoptr(GVariant) val = NULL;
g_autoptr(GVariant) val2 = NULL; g_autoptr(GVariant) val2 = NULL;
g_autoptr(GVariant) val3 = NULL; g_autoptr(GVariant) val3 = NULL;
g_autoptr(GVariant) val4 = NULL;
g_autoptr(GVariant) val5 = NULL;
g_autoptr(GVariant) val6 = NULL;
g_autoptr(GVariant) val7 = NULL;
g_autoptr(GMutexLocker) locker = NULL; g_autoptr(GMutexLocker) locker = NULL;
proxy = g_dbus_proxy_new_finish (res, &error); proxy = g_dbus_proxy_new_finish (res, &error);
@ -481,18 +485,18 @@ fwupd_client_connect_get_proxy_cb (GObject *source,
val3 = g_dbus_proxy_get_cached_property (priv->proxy, "Status"); val3 = g_dbus_proxy_get_cached_property (priv->proxy, "Status");
if (val3 != NULL) if (val3 != NULL)
fwupd_client_set_status (self, g_variant_get_uint32 (val3)); fwupd_client_set_status (self, g_variant_get_uint32 (val3));
val2 = g_dbus_proxy_get_cached_property (priv->proxy, "Interactive"); val4 = g_dbus_proxy_get_cached_property (priv->proxy, "Interactive");
if (val2 != NULL) if (val4 != NULL)
priv->interactive = g_variant_get_boolean (val2); priv->interactive = g_variant_get_boolean (val4);
val = g_dbus_proxy_get_cached_property (priv->proxy, "HostProduct"); val5 = g_dbus_proxy_get_cached_property (priv->proxy, "HostProduct");
if (val != NULL) if (val5 != NULL)
fwupd_client_set_host_product (self, g_variant_get_string (val, NULL)); fwupd_client_set_host_product (self, g_variant_get_string (val5, NULL));
val = g_dbus_proxy_get_cached_property (priv->proxy, "HostMachineId"); val6 = g_dbus_proxy_get_cached_property (priv->proxy, "HostMachineId");
if (val != NULL) if (val6 != NULL)
fwupd_client_set_host_machine_id (self, g_variant_get_string (val, NULL)); fwupd_client_set_host_machine_id (self, g_variant_get_string (val6, NULL));
val = g_dbus_proxy_get_cached_property (priv->proxy, "HostSecurityId"); val7 = g_dbus_proxy_get_cached_property (priv->proxy, "HostSecurityId");
if (val != NULL) if (val7 != NULL)
fwupd_client_set_host_security_id (self, g_variant_get_string (val, NULL)); fwupd_client_set_host_security_id (self, g_variant_get_string (val7, NULL));
/* success */ /* success */
g_task_return_boolean (task, TRUE); g_task_return_boolean (task, TRUE);