From 4e0bb5d5c943fe76aad427acb6a444da8cf4ad3a Mon Sep 17 00:00:00 2001 From: Mario Limonciello Date: Fri, 7 Sep 2018 23:32:03 -0500 Subject: [PATCH] trivial: uefi: fix a signed vs unsigned issue MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This started popping up in Arch CI: ../fwupd/plugins/uefi/fu-uefi-vars.c: In function ‘fu_uefi_vars_get_data’: ../fwupd/plugins/uefi/fu-uefi-vars.c:233:9: error: pointer targets in assignment from ‘gchar *’ {aka ‘char *’} to ‘guint8 *’ {aka ‘unsigned char *’} differ in signedness [-Werror=pointer-sign] *data = g_steal_pointer (&data_tmp); ^ --- plugins/uefi/fu-uefi-vars.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/uefi/fu-uefi-vars.c b/plugins/uefi/fu-uefi-vars.c index da32e0367..d776d05cb 100644 --- a/plugins/uefi/fu-uefi-vars.c +++ b/plugins/uefi/fu-uefi-vars.c @@ -224,7 +224,7 @@ fu_uefi_vars_get_data (const gchar *guid, const gchar *name, guint8 **data, if (data_sz != NULL) *data_sz = data_sz_tmp; if (data != NULL) { - g_autofree gchar *data_tmp = g_malloc0 (data_sz_tmp); + g_autofree guint8 *data_tmp = g_malloc0 (data_sz_tmp); if (!g_input_stream_read_all (istr, data_tmp, data_sz_tmp, NULL, NULL, error)) { g_prefix_error (error, "failed to read data: ");