From 4822b3317bd273aafcfd04d64d19c424f8ed79d5 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Mon, 15 Feb 2021 15:43:30 +0000 Subject: [PATCH] ccgx: Check for FPE when parsing the metadata section --- plugins/ccgx/fu-ccgx-firmware.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/plugins/ccgx/fu-ccgx-firmware.c b/plugins/ccgx/fu-ccgx-firmware.c index 7b5bc7762..96ed713d4 100644 --- a/plugins/ccgx/fu-ccgx-firmware.c +++ b/plugins/ccgx/fu-ccgx-firmware.c @@ -236,6 +236,13 @@ fu_ccgx_firmware_parse_md_block (FuCcgxFirmware *self, FuFirmwareImage *img, GEr g_autofree gchar *version_str = NULL; rcd = g_ptr_array_index (self->records, rcd_version_idx); buf = g_bytes_get_data (rcd->data, &bufsz); + if (bufsz == 0) { + g_set_error_literal (error, + FWUPD_ERROR, + FWUPD_ERROR_INVALID_FILE, + "metadata record had zero size"); + return FALSE; + } if (!fu_common_read_uint32_safe (buf, bufsz, CCGX_APP_VERSION_OFFSET % bufsz, &version, G_LITTLE_ENDIAN, error)) return FALSE;