proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-13 17:23:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ata: Correct activation functionality

Browse Source 
No data is actually exchanged in the activation flow.

The commands need to be sent in the direction `SG_DXFER_NONE` to
avoid ATA errors.
This commit is contained in:
Mario Limonciello 2019-03-26 15:26:36 -04:00 committed by Richard Hughes
parent 4bae7a2fa8
commit 3cdd558fe4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/ata/fu-ata-device.c
View File

@ -474,9 +474,9 @@ fu_ata_device_activate (FuDevice *device, GError **error)
struct ata_tf tf = { 0x0 }; struct ata_tf tf = { 0x0 };
/* flush caches and make sure drive is ready to activate */ /* flush caches and make sure drive is ready to activate */
tf.dev = 0xa0 | ATA_USING_LBA; tf.dev = ATA_USING_LBA;
tf.command = ATA_OP_STANDBY_IMMEDIATE; tf.command = ATA_OP_STANDBY_IMMEDIATE;
if (!fu_ata_device_command (self, &tf, SG_DXFER_TO_DEV, if (!fu_ata_device_command (self, &tf, SG_DXFER_NONE,
120 * 1000, /* a long time! */ 120 * 1000, /* a long time! */
NULL, 0, error)) { NULL, 0, error)) {
g_prefix_error (error, "failed to standby immediate: "); g_prefix_error (error, "failed to standby immediate: ");
@ -484,9 +484,10 @@ fu_ata_device_activate (FuDevice *device, GError **error)
} }
/* load the new firmware */ /* load the new firmware */
tf.dev = 0x0a | ATA_USING_LBA;
tf.command = ATA_OP_DOWNLOAD_MICROCODE; tf.command = ATA_OP_DOWNLOAD_MICROCODE;
tf.feat = ATA_SUBCMD_MICROCODE_ACTIVATE; tf.feat = ATA_SUBCMD_MICROCODE_ACTIVATE;
if (!fu_ata_device_command (self, &tf, SG_DXFER_TO_DEV, if (!fu_ata_device_command (self, &tf, SG_DXFER_NONE,
120 * 1000, /* a long time! */ 120 * 1000, /* a long time! */
NULL, 0, error)) { NULL, 0, error)) {
g_prefix_error (error, "failed to activate firmware: "); g_prefix_error (error, "failed to activate firmware: ");