From 38c7c334f4743b01f97bbd62d2702d298f4badf2 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Mon, 6 Aug 2018 10:59:09 +0100 Subject: [PATCH] trivial: Remove duplicate requirement checks The fu_engine_check_requirements() tests are already called from fu_engine_get_result_from_app() using a NULL device. --- src/fu-engine.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/fu-engine.c b/src/fu-engine.c index ac68eed89..5afc01364 100644 --- a/src/fu-engine.c +++ b/src/fu-engine.c @@ -2119,14 +2119,6 @@ fu_engine_get_details (FuEngine *self, gint fd, GError **error) for (guint i = 0; i < apps->len; i++) { AsApp *app = g_ptr_array_index (apps, i); FwupdDevice *dev; - g_autoptr(FuInstallTask) task = NULL; - - /* check we can install it */ - task = fu_install_task_new (NULL, app); - if (!fu_engine_check_requirements (self, task, - FWUPD_INSTALL_FLAG_NONE, - error)) - return NULL; as_app_set_origin (app, as_store_get_origin (store)); dev = fu_engine_get_result_from_app (self, app, error);