From 352f2c9b49d814781b9d40b7a70c069f5368d5b4 Mon Sep 17 00:00:00 2001
From: Mario Limonciello <mario.limonciello@dell.com>
Date: Tue, 12 Jun 2018 12:02:41 -0500
Subject: [PATCH] trivial: snap: fix bash completion

Since the snap is named fwupd, fwupdtool gets namespaced as
fwupd.fwupdtool so bash completion doesn't work properly.

Add a step to fixup bash completion paths
---
 contrib/snap/fix-bash-completion/Makefile | 7 +++++++
 contrib/snap/snapcraft-stable.yaml        | 5 ++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 contrib/snap/fix-bash-completion/Makefile

diff --git a/contrib/snap/fix-bash-completion/Makefile b/contrib/snap/fix-bash-completion/Makefile
new file mode 100644
index 000000000..ebaeca324
--- /dev/null
+++ b/contrib/snap/fix-bash-completion/Makefile
@@ -0,0 +1,7 @@
+build:
+	true
+install:
+	#fixes up fwupdtool -> fwupd.fwupdtool
+	sed -i "s,\(complete -F _fwupd[a-z]*\) \(fwupd.*\),\1 fwupd.\2,; 		\
+		s,\(command.*\)\(fwupdtool\),\1fwupd.\2," 				\
+			${SNAPCRAFT_STAGE}/usr/share/bash-completion/completions/*
diff --git a/contrib/snap/snapcraft-stable.yaml b/contrib/snap/snapcraft-stable.yaml
index d4e092697..56225ef57 100644
--- a/contrib/snap/snapcraft-stable.yaml
+++ b/contrib/snap/snapcraft-stable.yaml
@@ -20,7 +20,6 @@ apps:
 
 plugs:
   fwupdtool:
-    interface: fwupd
     interface: home
 
 parts:
@@ -261,6 +260,10 @@ parts:
       - -usr/lib/*/glib-2.0
       - -usr/lib/*/pkgconfig
     after: [appstream-glib-dev, libfwup-dev, gudev, gusb]
+  fix-bash-completion:
+    plugin: make
+    source: contrib/snap/fix-bash-completion
+    after: [fwupd]
   update-mime:
     plugin: make
     source: contrib/snap/update-mime