proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-16 10:06:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

redfish: Only create users using IPMI when we know it's going to work

Browse Source 
Make the IPMI auto-account feature allow-listed on specific vendors as some IPMI
implementations are not specification compliant and do entirely the wrong thing.
This commit is contained in:
Richard Hughes 2022-09-20 09:13:52 +01:00
parent 096364199b
commit 2fb81a6482
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/redfish/fu-plugin-redfish.c
View File

@ -436,6 +436,14 @@ fu_plugin_redfish_startup(FuPlugin *plugin, FuProgress *progress, GError **error
#ifdef HAVE_LINUX_IPMI_H
/* we got neither a type 42 entry or config value, lets try IPMI */
if (fu_redfish_backend_get_username(priv->backend) == NULL) {
if (!fu_context_has_hwid_flag(fu_plugin_get_context(plugin), "ipmi-create-user")) {
g_set_error_literal(error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"no username and password specified, "
"and no vendor quirk for 'ipmi-create-user'");
return FALSE;
}
if (!fu_plugin_get_config_value_boolean(plugin, "IpmiDisableCreateUser")) {
g_debug("attempting to create user using IPMI");
if (!fu_redfish_plugin_ipmi_create_user(plugin, error))

2
plugins/redfish/redfish.quirk
View File

@ -1,6 +1,6 @@
# Lenovo ThinkSystem
[42f00735-c9ab-5374-bd63-a5deee5881e0]
Flags = wildcard-targets,reset-required
Flags = wildcard-targets,reset-required,ipmi-create-user
[REDFISH\VENDOR_Lenovo&ID_BMC-Backup]
ParentGuid = REDFISH\VENDOR_Lenovo&ID_BMC-Primary