proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-05 22:47:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

synaptics-rmi: Fix Coverity issue that is impossible to hit in reality

Browse Source 
The guint16 was promoted to (signed) int for the multiplication, which meant
that the highest address possible was 0x7FFFFFFF not 0xFFFFFFFF. Which doesn't
really matter in reality, as all addresses are much smaller than that now.
This commit is contained in:
Richard Hughes 2020-02-07 13:40:24 +00:00
parent 072efbde88
commit 2f85c24363
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/synaptics-rmi/fu-synaptics-rmi-v7-device.c
View File

@ -465,7 +465,7 @@ fu_synaptics_rmi_device_read_flash_config_v7 (FuSynapticsRmiDevice *self, GError
/* read back entire buffer in blocks */
res = fu_synaptics_rmi_device_read (self,
f34->data_base + 0x5,
flash->block_size * flash->config_length,
(guint32) flash->block_size * (guint32) flash->config_length,
error);
if (res == NULL) {
g_prefix_error (error, "failed to read: ");
@ -533,6 +533,18 @@ fu_synaptics_rmi_v7_device_setup (FuSynapticsRmiDevice *self, GError **error)
flash->config_length = fu_common_read_uint16 (f34_dataX->data + 0x0d, G_LITTLE_ENDIAN);
flash->payload_length = fu_common_read_uint16 (f34_dataX->data + 0x0f, G_LITTLE_ENDIAN);
flash->build_id = fu_common_read_uint32 (f34_dataX->data + 0x02, G_LITTLE_ENDIAN);
/* sanity check */
if ((guint32) flash->block_size * (guint32) flash->config_length > G_MAXUINT16) {
g_set_error (error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"block size 0x%x or config length 0x%x invalid",
flash->block_size, flash->config_length);
return FALSE;
}
/* read flash config */
return fu_synaptics_rmi_device_read_flash_config_v7 (self, error);
}