From 2d22ee2faea6ccb0bfc95f6fa8d1cf15ba606693 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Thu, 1 Oct 2020 13:25:15 +0100 Subject: [PATCH] Remove 16 extra lines of debugging at startup On my system I get 16 lines of 'device overwriting same name value' for the ME device. Once we set valid metadata about a device just remove the flag to stop scanning for every call to fu_engine_ensure_device_supported() --- src/fu-engine.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/fu-engine.c b/src/fu-engine.c index 222862741..052fea628 100644 --- a/src/fu-engine.c +++ b/src/fu-engine.c @@ -3075,8 +3075,10 @@ fu_engine_md_refresh_device_name (FuEngine *self, FuDevice *device, XbNode *comp /* copy 1:1 */ name = xb_node_query_text (component, "name", NULL); - if (name != NULL) + if (name != NULL) { fu_device_set_name (device, name); + fu_device_remove_flag (device, FWUPD_DEVICE_FLAG_MD_SET_NAME); + } } static const gchar * @@ -3119,8 +3121,10 @@ fu_engine_md_refresh_device_name_category (FuEngine *self, FuDevice *device, XbN if (name != NULL) break; } - if (name != NULL) + if (name != NULL) { fu_device_set_name (device, name); + fu_device_remove_flag (device, FWUPD_DEVICE_FLAG_MD_SET_NAME_CATEGORY); + } } static void @@ -3176,6 +3180,9 @@ fu_engine_md_refresh_device_verfmt (FuEngine *self, FuDevice *device, XbNode *co fu_device_set_version_bootloader (device, version); } } + + /* do not try to do this again */ + fu_device_remove_flag (device, FWUPD_DEVICE_FLAG_MD_SET_VERFMT); } void