proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-06-01 11:10:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: Fix a potential OOB write that can't actually happen

Browse Source
This commit is contained in:
Richard Hughes 2022-04-13 10:43:39 +01:00
parent 500dd2c9c4
commit 2883b577dc
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libfwupdplugin/fu-device.c
View File

@ -481,6 +481,7 @@ fu_device_get_request_cnt(FuDevice *self, FwupdRequestKind request_kind)
{
FuDevicePrivate *priv = GET_PRIVATE(self);
g_return_val_if_fail(FU_IS_DEVICE(self), G_MAXUINT);
g_return_val_if_fail(request_kind < FWUPD_REQUEST_KIND_LAST, G_MAXUINT);
return priv->request_cnts[request_kind];
}
@ -4770,6 +4771,10 @@ fu_device_emit_request(FuDevice *self, FwupdRequest *request)
g_critical("a request must have an assigned ID");
return;
}
if (fwupd_request_get_kind(request) >= FWUPD_REQUEST_KIND_LAST) {
g_critical("invalid request kind");
return;
}
/* ensure set */
fwupd_request_set_device_id(request, fu_device_get_id(self));