From 2815a302740095dbbac8c0b35bb8f429e1ff5e29 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Thu, 5 Aug 2021 11:46:50 +0100 Subject: [PATCH] elantp: Fix a crash when starting the daemon FuElantpHidDevice derives from FuUdevDevice, not FuUsbDevice -- and the former does not define a class->setup vfunc. Fixes https://github.com/fwupd/fwupd/issues/3548 --- plugins/elantp/fu-elantp-hid-device.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/plugins/elantp/fu-elantp-hid-device.c b/plugins/elantp/fu-elantp-hid-device.c index f9c4dc6ae..54ac55983 100644 --- a/plugins/elantp/fu-elantp-hid-device.c +++ b/plugins/elantp/fu-elantp-hid-device.c @@ -161,10 +161,6 @@ fu_elantp_hid_device_setup (FuDevice *device, GError **error) g_autofree gchar *version_bl = NULL; g_autofree gchar *version = NULL; - /* FuUsbDevice->setup */ - if (!FU_DEVICE_CLASS (fu_elantp_hid_device_parent_class)->setup (device, error)) - return FALSE; - /* get pattern */ if (!fu_elantp_hid_device_read_cmd (self, ETP_CMD_I2C_GET_HID_ID,