proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-27 02:24:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

redfish: Use secure helper to set file permissions when setting password

Browse Source 
Instead of installing the conf file as locked down, set permissions when
using it.

This fixes a problem on snap first run:
```
cp: cannot open '/snap/fwupd/x1/etc/fwupd/redfish.conf' for reading: Permission denied
```
This commit is contained in:
Mario Limonciello 2021-12-16 14:24:25 -06:00 committed by Mario Limonciello
parent 17db067d13
commit 22057f76cc
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/redfish/fu-plugin-redfish.c
View File

@ -272,10 +272,11 @@ fu_redfish_plugin_ipmi_create_user(FuPlugin *plugin, GError **error)
fu_redfish_backend_set_password(data->backend, password_new);
/* success */
if (!fu_plugin_set_config_value(plugin, "Username", username_fwupd, error))
if (!fu_plugin_set_secure_config_value(plugin, "Username", username_fwupd, error))
return FALSE;
if (!fu_plugin_set_config_value(plugin, "Password", password_new, error))
if (!fu_plugin_set_secure_config_value(plugin, "Password", password_new, error))
return FALSE;
return TRUE;
}
#endif

1
plugins/redfish/meson.build
View File

@ -54,7 +54,6 @@ shared_module('fu_plugin_redfish',
install_data(['redfish.conf'],
install_dir: join_paths(sysconfdir, 'fwupd'),
install_mode: 'rw-r-----',
)
if get_option('tests')