proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-05-17 05:25:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dell: Stop showing errors when no dock plugged in

Browse Source 
Since it matches the Realtek dongle, shouldn't show this error:

failed to add USB device 0bda:8153: no dock detected

All the time when that dongle is plugged in
This commit is contained in:
Mario Limonciello 2018-09-11 10:38:19 -05:00 committed by Richard Hughes
parent 36a2bd06ec
commit 20447a00ae
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/dell/fu-plugin-dell.c
View File

@ -351,9 +351,8 @@ fu_plugin_usb_device_added (FuPlugin *plugin,
buf.buf = NULL; buf.buf = NULL;
if (!fu_dell_query_dock (data->smi_obj, &buf)) { if (!fu_dell_query_dock (data->smi_obj, &buf)) {
g_set_error_literal (error, FWUPD_ERROR, FWUPD_ERROR_NOT_SUPPORTED, g_debug ("no dock detected");
"no dock detected"); return TRUE;
return FALSE;
} }
if (buf.record->dock_info_header.dir_version != 1) { if (buf.record->dock_info_header.dir_version != 1) {

2
plugins/dell/fu-self-test.c
View File

@ -301,7 +301,7 @@ fu_plugin_dell_dock_func (void)
DOCK_NIC_VID, DOCK_NIC_PID, DOCK_NIC_VID, DOCK_NIC_PID,
NULL, FALSE); NULL, FALSE);
ret = fu_plugin_usb_device_added (plugin_dell, NULL, &error); ret = fu_plugin_usb_device_added (plugin_dell, NULL, &error);
g_assert_false (ret); g_assert_true (ret);
g_clear_error (&error); g_clear_error (&error);
g_assert_cmpint (devices->len, ==, 0); g_assert_cmpint (devices->len, ==, 0);