From 1ca9c92919d56bddfa18311a646c3241076ee1db Mon Sep 17 00:00:00 2001 From: Daniil Lunev Date: Tue, 13 Jul 2021 11:49:30 +1000 Subject: [PATCH] emmc: add check "name" sysattr is not NULL At this point it has to be present, but better have the check for correctness sake. Follow up of https://github.com/fwupd/fwupd/commit/64fa633e3029ff619a2de86e85e7fbb60cc40225 Change-Id: I51b5995e25dc4dc4ec63b90af271cd90650d184d --- plugins/emmc/fu-emmc-device.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/plugins/emmc/fu-emmc-device.c b/plugins/emmc/fu-emmc-device.c index f59968900..e6e4e7794 100644 --- a/plugins/emmc/fu-emmc-device.c +++ b/plugins/emmc/fu-emmc-device.c @@ -178,6 +178,14 @@ fu_emmc_device_probe (FuDevice *device, GError **error) /* name */ tmp = g_udev_device_get_sysfs_attr (udev_parent, "name"); + if (tmp == NULL) { + g_set_error (error, + FWUPD_ERROR, + FWUPD_ERROR_NOT_SUPPORTED, + "%s does not have 'name' sysattr", + fu_device_get_name (device)); + return FALSE; + } fu_device_set_name (device, tmp); name_only = g_strdup_printf ("EMMC\\%s", fu_device_get_name (device)); fu_device_add_instance_id (device, name_only);