proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-11-01 12:48:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix libdfu CRC check for big endian architectures

Browse Source 
dfu_firmware_generate_crc32() generates a uint in the host byte order, the
proper fix is to write the checksum in LE format like the other fields.
This commit is contained in:
Richard Hughes 2016-04-03 09:39:23 +01:00
parent 540df18d97
commit 1b853eb971
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libdfu/dfu-firmware.c
View File

@ -1016,7 +1016,7 @@ dfu_firmware_parse_data (DfuFirmware *firmware, GBytes *bytes,
/* verify the checksum */
priv->crc = GUINT32_FROM_LE (ftr->crc);
if ((flags & DFU_FIRMWARE_PARSE_FLAG_NO_CRC_TEST) == 0) {
crc_new = GUINT32_FROM_LE (dfu_firmware_generate_crc32 (data, len - 4));
crc_new = dfu_firmware_generate_crc32 (data, len - 4);
if (priv->crc != crc_new) {
g_set_error (error,
DFU_ERROR,
@ -1258,6 +1258,7 @@ dfu_firmware_add_footer (DfuFirmware *firmware, GBytes *contents, GError **error
const guint8 *data_md;
gsize length_bin = 0;
gsize length_md = 0;
guint32 crc_new;
guint8 *buf;
g_autoptr(GBytes) metadata_table = NULL;
@ -1283,7 +1284,8 @@ dfu_firmware_add_footer (DfuFirmware *firmware, GBytes *contents, GError **error
ftr->ver = GUINT16_TO_LE (priv->format);
ftr->len = GUINT16_TO_LE (0x10 + length_md);
memcpy(ftr->sig, "UFD", 3);
ftr->crc = dfu_firmware_generate_crc32 (buf, length_bin + length_md + 12);
crc_new = dfu_firmware_generate_crc32 (buf, length_bin + length_md + 12);
ftr->crc = GUINT32_TO_LE (crc_new);
/* return all data */
return g_bytes_new_take (buf, length_bin + length_md + 0x10);