proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-14 10:44:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: dell-dock: fail when EC indicates flashing an invalid/unsigned image

Browse Source 
Otherwise this would cause fwupd to sit in an endless loop when providing a bad
image.

This additional enum is only available in EC16, but since it doesn't break existing
API on older EC images, don't bump minimum requirement to EC16 yet.
This commit is contained in:
Mario Limonciello 2018-11-26 14:05:19 -06:00 committed by Richard Hughes
parent ec6190c4bf
commit 1210332e05
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/dell-dock/fu-dell-dock-i2c-ec.c
View File

@ -40,6 +40,7 @@
typedef enum { typedef enum {
FW_UPDATE_IN_PROGRESS, FW_UPDATE_IN_PROGRESS,
FW_UPDATE_COMPLETE, FW_UPDATE_COMPLETE,
FW_UPDATE_AUTHENTICATION_FAILED,
} FuDellDockECFWUpdateStatus; } FuDellDockECFWUpdateStatus;
const FuHIDI2CParameters ec_base_settings = { const FuHIDI2CParameters ec_base_settings = {
@ -723,6 +724,13 @@ fu_dell_dock_ec_write_fw (FuDevice *device, GBytes *blob_fw,
error_local->message, status); error_local->message, status);
return TRUE; return TRUE;
} }
if (status == FW_UPDATE_AUTHENTICATION_FAILED) {
g_set_error_literal (error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"invalid EC firmware image");
return FALSE;
}
} }
/* dock will reboot to re-read; this is to appease the daemon */ /* dock will reboot to re-read; this is to appease the daemon */