proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-05-15 18:36:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: Fix a 'Comparison is always true' LGTM warning

Browse Source 
Not a bug, but somewhat muddled logic I guess.
This commit is contained in:
Richard Hughes 2019-02-12 08:54:20 +00:00 committed by Mario Limonciello
parent 71cc366522
commit 10b2fef1bd
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/uefi/fu-uefi-common.c
View File

@ -376,17 +376,14 @@ gboolean
fu_uefi_prefix_efi_errors (GError **error) fu_uefi_prefix_efi_errors (GError **error)
{ {
g_autoptr(GString) str = g_string_new (NULL); g_autoptr(GString) str = g_string_new (NULL);
gint rc = 1; for (gint i = 0; ; i++) {
for (gint i = 0; rc > 0; i++) {
gchar *filename = NULL; gchar *filename = NULL;
gchar *function = NULL; gchar *function = NULL;
gchar *message = NULL; gchar *message = NULL;
gint line = 0; gint line = 0;
gint err = 0; gint err = 0;
if (efi_error_get (i, &filename, &function, &line,
rc = efi_error_get (i, &filename, &function, &line, &message, &err) <= 0)
&message, &err);
if (rc <= 0)
break; break;
g_string_append_printf (str, "{error #%d} %s:%d %s(): %s: %s\t", g_string_append_printf (str, "{error #%d} %s:%d %s(): %s: %s\t",
i, filename, line, function, i, filename, line, function,