proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-03 05:50:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

synaprom: Do not add zero sized images

Browse Source 
This prevents a DoS when parsing corrupt firmware.
This commit is contained in:
Richard Hughes 2020-12-10 08:58:09 +00:00
parent 976b6afe63
commit 0eb8b6a2a8
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/synaptics-prometheus/fu-synaprom-firmware.c
View File

@ -100,6 +100,14 @@ fu_synaprom_firmware_parse (FuFirmware *firmware,
return FALSE;
}
hdrsz = GUINT32_FROM_LE(header.bufsz);
if (hdrsz == 0) {
g_set_error (error,
G_IO_ERROR,
G_IO_ERROR_INVALID_DATA,
"empty header for tag 0x%04x",
tag);
return FALSE;
}
offset += sizeof(header) + hdrsz;
if (offset > bufsz) {
g_set_error (error,