proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-09 20:42:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

synaptics-mst: Check the firmware payload size when updating cayenne

Browse Source 
PVS: Parameter 'payload_len' is always rewritten in function body before being used.
This commit is contained in:
Richard Hughes 2022-09-09 10:52:54 +01:00
parent 07b368d6b1
commit 0c80952e30
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/synaptics-mst/fu-synaptics-mst-device.c
View File

@ -42,6 +42,8 @@
#define FLASH_SETTLE_TIME 5000000 /* us */ #define FLASH_SETTLE_TIME 5000000 /* us */
#define CAYENNE_FIRMWARE_SIZE 0x50000 /* bytes */
/** /**
* FU_SYNAPTICS_MST_DEVICE_FLAG_IGNORE_BOARD_ID: * FU_SYNAPTICS_MST_DEVICE_FLAG_IGNORE_BOARD_ID:
* *
@ -860,7 +862,17 @@ fu_synaptics_mst_device_update_cayenne_firmware(FuSynapticsMstDevice *self,
guint32 offset = 0; guint32 offset = 0;
guint32 write_loops = 0; guint32 write_loops = 0;
payload_len = 0x50000; /* sanity check */
if (payload_len < CAYENNE_FIRMWARE_SIZE) {
g_set_error(error,
G_IO_ERROR,
G_IO_ERROR_INVALID_DATA,
"payload too small, expected >=0x%x",
(guint)CAYENNE_FIRMWARE_SIZE);
return FALSE;
}
payload_len = CAYENNE_FIRMWARE_SIZE;
write_loops = (payload_len / BLOCK_UNIT); write_loops = (payload_len / BLOCK_UNIT);
data_to_write = payload_len; data_to_write = payload_len;