proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-27 16:16:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

redfish: Be more resilient when restarting the BMC

Browse Source
This commit is contained in:
Richard Hughes 2022-05-24 13:47:56 +01:00
parent 317887cf85
commit 0ad49b444e
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
plugins/redfish/fu-plugin-redfish.c
View File

@ -418,13 +418,20 @@ fu_plugin_redfish_startup(FuPlugin *plugin, GError **error)
} }
static gboolean static gboolean
fu_plugin_redfish_cleanup_cb(FuDevice *device, gpointer user_data, GError **error) fu_plugin_redfish_cleanup_setup_cb(FuDevice *device, gpointer user_data, GError **error)
{ {
FuPlugin *self = FU_PLUGIN(user_data); FuPlugin *self = FU_PLUGIN(user_data);
FuPluginData *data = fu_plugin_get_data(self); FuPluginData *data = fu_plugin_get_data(self);
return fu_backend_setup(FU_BACKEND(data->backend), error); return fu_backend_setup(FU_BACKEND(data->backend), error);
} }
static gboolean
fu_plugin_redfish_cleanup_coldplug_cb(FuDevice *device, gpointer user_data, GError **error)
{
FuPlugin *self = FU_PLUGIN(user_data);
return fu_plugin_redfish_coldplug(self, error);
}
static gboolean static gboolean
fu_plugin_redfish_cleanup(FuPlugin *self, fu_plugin_redfish_cleanup(FuPlugin *self,
FuDevice *device, FuDevice *device,
@ -491,12 +498,12 @@ fu_plugin_redfish_cleanup(FuPlugin *self,
/* wait for the BMC to come back */ /* wait for the BMC to come back */
if (!fu_device_retry_full(device, if (!fu_device_retry_full(device,
fu_plugin_redfish_cleanup_cb, fu_plugin_redfish_cleanup_setup_cb,
reset_timeout / FU_REDFISH_PLUGIN_CLEANUP_RETRIES_DELAY, reset_timeout / FU_REDFISH_PLUGIN_CLEANUP_RETRIES_DELAY,
FU_REDFISH_PLUGIN_CLEANUP_RETRIES_DELAY * 1000, FU_REDFISH_PLUGIN_CLEANUP_RETRIES_DELAY * 1000,
self, self,
error)) { error)) {
g_prefix_error(error, "manager failed to come back: "); g_prefix_error(error, "manager failed to come back from setup: ");
return FALSE; return FALSE;
} }
fu_progress_step_done(progress); fu_progress_step_done(progress);
@ -507,8 +514,15 @@ fu_plugin_redfish_cleanup(FuPlugin *self,
fu_progress_step_done(progress); fu_progress_step_done(progress);
/* get the new list of devices */ /* get the new list of devices */
if (!fu_plugin_redfish_coldplug(self, error)) if (!fu_device_retry_full(device,
fu_plugin_redfish_cleanup_coldplug_cb,
reset_timeout / FU_REDFISH_PLUGIN_CLEANUP_RETRIES_DELAY,
FU_REDFISH_PLUGIN_CLEANUP_RETRIES_DELAY * 1000,
self,
error)) {
g_prefix_error(error, "manager failed to come back from coldplug: ");
return FALSE; return FALSE;
}
fu_progress_step_done(progress); fu_progress_step_done(progress);
/* success */ /* success */