proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-14 13:42:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

uefi: More carefully check the output from tpm2_pcrlist

Browse Source 
Otherwise we can get a PCR0 of 'getcapability:getpcrallocationstatuserror'...
This commit is contained in:
Richard Hughes 2019-03-27 14:40:51 +00:00
parent 77d97406f2
commit 0a57b90d75
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/uefi/fu-uefi-pcrs.c
View File

@ -21,6 +21,16 @@ struct _FuUefiPcrs {
G_DEFINE_TYPE (FuUefiPcrs, fu_uefi_pcrs, G_TYPE_OBJECT) G_DEFINE_TYPE (FuUefiPcrs, fu_uefi_pcrs, G_TYPE_OBJECT)
static gboolean
_g_string_isxdigit (GString *str)
{
for (gsize i = 0; i < str->len; i++) {
if (!g_ascii_isxdigit (str->str[i]))
return FALSE;
}
return TRUE;
}
static void static void
fu_uefi_pcrs_parse_line (const gchar *line, gpointer user_data) fu_uefi_pcrs_parse_line (const gchar *line, gpointer user_data)
{ {
@ -34,7 +44,7 @@ fu_uefi_pcrs_parse_line (const gchar *line, gpointer user_data)
/* split into index:hash */ /* split into index:hash */
if (line == NULL || line[0] == '\0') if (line == NULL || line[0] == '\0')
return; return;
split = g_strsplit (line, ":", 2); split = g_strsplit (line, ":", -1);
if (g_strv_length (split) != 2) { if (g_strv_length (split) != 2) {
g_debug ("unexpected format, skipping: %s", line); g_debug ("unexpected format, skipping: %s", line);
return; return;
@ -50,9 +60,11 @@ fu_uefi_pcrs_parse_line (const gchar *line, gpointer user_data)
/* parse hash */ /* parse hash */
str = g_string_new (split[1]); str = g_string_new (split[1]);
if (str->len < 16)
return;
fu_common_string_replace (str, " ", ""); fu_common_string_replace (str, " ", "");
if ((str->len != 40 && str->len != 64) || !_g_string_isxdigit (str)) {
g_debug ("not SHA-1 or SHA-256, skipping: %s", split[1]);
return;
}
g_string_ascii_down (str); g_string_ascii_down (str);
item = g_new0 (FuUefiPcrItem, 1); item = g_new0 (FuUefiPcrItem, 1);
item->idx = idx; item->idx = idx;