proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-02 14:50:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a regression when getting the i2c bus number

Browse Source 
When I replaced the regex with a fu_strtoull() in bb548f15 I missed that the
regex looked at the 2nd-to-last sysfs path element, e.g. the i2c bus number for
/sys/devices/pci0000:00/0000:00:15.2/i2c_designware.1/i2c-1/i2c-1AF80175:00 is
actually '1'.

This fixes enumerating the parade-lspcon on a Puff ChromeBox.
This commit is contained in:
Richard Hughes 2022-10-07 11:59:57 +01:00
parent b244057d4f
commit 0110a3ebdf
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libfwupdplugin/fu-i2c-device.c
View File

@ -115,6 +115,7 @@ fu_i2c_device_probe(FuDevice *device, GError **error)
GUdevDevice *udev_device = fu_udev_device_get_dev(FU_UDEV_DEVICE(device));
const gchar *tmp;
g_autofree gchar *devname = NULL;
g_autoptr(GUdevDevice) udev_parent = NULL;
#endif
/* set physical ID */
@ -129,7 +130,8 @@ fu_i2c_device_probe(FuDevice *device, GError **error)
return FALSE;
/* get bus number out of sysfs path */
devname = g_path_get_basename(fu_udev_device_get_sysfs_path(FU_UDEV_DEVICE(device)));
udev_parent = g_udev_device_get_parent(udev_device);
devname = g_path_get_basename(g_udev_device_get_sysfs_path(udev_parent));
if (g_str_has_prefix(devname, "i2c-")) {
guint64 tmp64 = 0;
g_autoptr(GError) error_local = NULL;