mirror of
https://git.proxmox.com/git/efi-boot-shim
synced 2025-08-15 12:12:27 +00:00
111f82f2f6
Covscan sez:
720 FreePool(buffer);
assignment: Assigning: buffer = NULL.
721 buffer = NULL;
722
723 CHAR16 *bootcsv=NULL, *bootarchcsv=NULL;
724
725 bs = 0;
726 do {
727 bs = 0;
728 rc = uefi_call_wrapper(fh->Read, 3, fh, &bs, NULL);
729 if (EFI_ERROR(rc) && rc != EFI_BUFFER_TOO_SMALL) {
730 Print(L"Could not read \\EFI\\%s\\: %d\n", dirname, rc);
null: At condition buffer, the value of buffer must be NULL.
dead_error_condition: The condition buffer cannot be true.
731 if (buffer)
CID 182851 (#1 of 1): Logically dead code (DEADCODE)dead_error_line:
Execution cannot reach this statement: FreePool(buffer);.
732 FreePool(buffer);
733 return rc;
734 }
And it's right; buffer can never be non-NULL there. So just take that
out.
Signed-off-by: Peter Jones <pjones@redhat.com>
|
||
|---|---|---|
| Cryptlib | ||
| include | ||
| lib | ||
| .gitignore | ||
| .syntastic_c_config | ||
| buildid.c | ||
| BUILDING | ||
| cert.S | ||
| COPYRIGHT | ||
| crypt_blowfish.c | ||
| elf_aarch64_efi.lds | ||
| elf_arm_efi.lds | ||
| elf_ia32_efi.lds | ||
| elf_ia64_efi.lds | ||
| elf_x86_64_efi.lds | ||
| errlog.c | ||
| fallback.c | ||
| httpboot.c | ||
| make-certs | ||
| Make.coverity | ||
| Make.defaults | ||
| Make.rules | ||
| Make.scan-build | ||
| Makefile | ||
| model.c | ||
| MokManager.c | ||
| MokVars.txt | ||
| netboot.c | ||
| PasswordCrypt.c | ||
| README | ||
| README.fallback | ||
| README.tpm | ||
| replacements.c | ||
| shim.c | ||
| shim.h | ||
| testplan.txt | ||
| TODO | ||
| tpm.c | ||
| version.c.in | ||
| version.h | ||
shim is a trivial EFI application that, when run, attempts to open and execute another application. It will initially attempt to do this via the standard EFI LoadImage() and StartImage() calls. If these fail (because secure boot is enabled and the binary is not signed with an appropriate key, for instance) it will then validate the binary against a built-in certificate. If this succeeds and if the binary or signing key are not blacklisted then shim will relocate and execute the binary. shim will also install a protocol which permits the second-stage bootloader to perform similar binary validation. This protocol has a GUID as described in the shim.h header file and provides a single entry point. On 64-bit systems this entry point expects to be called with SysV ABI rather than MSABI, and so calls to it should not be wrapped. On systems with a TPM chip enabled and supported by the system firmware, shim will extend various PCRs with the digests of the targets it is loading. A full list is in the file README.tpm . To use shim, simply place a DER-encoded public certificate in a file such as pub.cer and build with "make VENDOR_CERT_FILE=pub.cer". There are a couple of build options, and a couple of ways to customize the build, described in BUILDING.