proxmox-mirrors/efi-boot-shim
1
0
Fork 0
mirror of https://git.proxmox.com/git/efi-boot-shim synced 2025-10-04 22:59:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

get_variable: always allocate a NUL character at the end.

Browse Source 
Sometimes we're loading structures that are parsed in string-like ways,
but can't necessarily be trusted to be zero-terminated.  Solve that by
making sure we always have enough aligned, trailing zero bytes to always
have at least one NUL character, no matter which character type is being
parsed.

Signed-off-by: Peter Jones <pjones@redhat.com>
This commit is contained in:
Peter Jones 2021-02-13 13:02:14 -05:00
parent 94ad063e94
commit b0a2ea0caa
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/variables.c
View File

@ -245,7 +245,11 @@ get_variable_attr(CHAR16 *var, UINT8 **data, UINTN *len, EFI_GUID owner,
return efi_status; return efi_status;
} }
*data = AllocateZeroPool(*len); /*
* Add three zero pad bytes; at least one correctly aligned UCS-2
* character.
*/
*data = AllocateZeroPool(*len + 3);
if (!*data) if (!*data)
return EFI_OUT_OF_RESOURCES; return EFI_OUT_OF_RESOURCES;
@ -254,6 +258,7 @@ get_variable_attr(CHAR16 *var, UINT8 **data, UINTN *len, EFI_GUID owner,
FreePool(*data); FreePool(*data);
*data = NULL; *data = NULL;
} }
return efi_status; return efi_status;
} }