proxmox-mirrors/efi-boot-shim
1
0
Fork 0
mirror of https://git.proxmox.com/git/efi-boot-shim synced 2025-06-06 16:52:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't free GetVariable() return data without checking the status code.

Browse Source 
This breaks every machine from before Secure Boot was a thing.

Signed-off-by: Peter Jones <pjones@redhat.com>
This commit is contained in:
Peter Jones 2013-10-30 16:36:01 -04:00
parent 83b3a7cf6d
commit 556c445ea1
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
shim.c
View File

@ -456,21 +456,30 @@ static BOOLEAN secure_mode (void)
return FALSE; return FALSE;
status = get_variable(L"SecureBoot", &Data, &len, global_var); status = get_variable(L"SecureBoot", &Data, &len, global_var);
if (status != EFI_SUCCESS) {
if (verbose)
console_notify(L"Secure boot not enabled\n");
return FALSE;
}
sb = *Data; sb = *Data;
FreePool(Data); FreePool(Data);
/* FIXME - more paranoia here? */ if (sb != 1) {
if (status != EFI_SUCCESS || sb != 1) {
if (verbose) if (verbose)
console_notify(L"Secure boot not enabled\n"); console_notify(L"Secure boot not enabled\n");
return FALSE; return FALSE;
} }
status = get_variable(L"SetupMode", &Data, &len, global_var); status = get_variable(L"SetupMode", &Data, &len, global_var);
if (status == EFI_SUCCESS) {
if (verbose)
console_notify(L"Platform is in setup mode\n");
return FALSE;
}
setupmode = *Data; setupmode = *Data;
FreePool(Data); FreePool(Data);
if (status == EFI_SUCCESS && setupmode == 1) { if (setupmode == 1) {
if (verbose) if (verbose)
console_notify(L"Platform is in setup mode\n"); console_notify(L"Platform is in setup mode\n");
return FALSE; return FALSE;