mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 03:13:13 +00:00
ff785fd517
This commit fixes handling of empty pairs that occur before the end of the query string so that they are also ignored. Additionally, some optimizations have been made, including: * Avoid unnecessary code execution where possible * Use a lookup table when checking for hex characters * Avoid forced decoding when '+' characters are encountered and we are using the default decoder Fixes: https://github.com/nodejs/node/issues/10454 PR-URL: https://github.com/nodejs/node/pull/11234 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Nicu Micleușanu <micnic90@gmail.com>
60 lines
2.0 KiB
JavaScript
60 lines
2.0 KiB
JavaScript
'use strict';
|
|
var common = require('../common.js');
|
|
var querystring = require('querystring');
|
|
var v8 = require('v8');
|
|
|
|
var inputs = {
|
|
noencode: 'foo=bar&baz=quux&xyzzy=thud',
|
|
multicharsep: 'foo=bar&&&&&&&&&&baz=quux&&&&&&&&&&xyzzy=thud',
|
|
encodefake: 'foo=%©ar&baz=%A©uux&xyzzy=%©ud',
|
|
encodemany: '%66%6F%6F=bar&%62%61%7A=quux&xyzzy=%74h%75d',
|
|
encodelast: 'foo=bar&baz=quux&xyzzy=thu%64',
|
|
multivalue: 'foo=bar&foo=baz&foo=quux&quuy=quuz',
|
|
multivaluemany: 'foo=bar&foo=baz&foo=quux&quuy=quuz&foo=abc&foo=def&' +
|
|
'foo=ghi&foo=jkl&foo=mno&foo=pqr&foo=stu&foo=vwxyz',
|
|
manypairs: 'a&b&c&d&e&f&g&h&i&j&k&l&m&n&o&p&q&r&s&t&u&v&w&x&y&z',
|
|
manyblankpairs: '&&&&&&&&&&&&&&&&&&&&&&&&',
|
|
altspaces: 'foo+bar=baz+quux&xyzzy+thud=quuy+quuz&abc=def+ghi'
|
|
};
|
|
|
|
var bench = common.createBenchmark(main, {
|
|
type: Object.keys(inputs),
|
|
n: [1e6],
|
|
});
|
|
|
|
// A deopt followed by a reopt of main() can happen right when the timed loop
|
|
// starts, which seems to have a noticeable effect on the benchmark results.
|
|
// So we explicitly disable optimization of main() to avoid this potential
|
|
// issue.
|
|
v8.setFlagsFromString('--allow_natives_syntax');
|
|
eval('%NeverOptimizeFunction(main)');
|
|
|
|
function main(conf) {
|
|
var type = conf.type;
|
|
var n = conf.n | 0;
|
|
var input = inputs[type];
|
|
var i;
|
|
|
|
// Note: we do *not* use OptimizeFunctionOnNextCall() here because currently
|
|
// it causes a deopt followed by a reopt, which could make its way into the
|
|
// timed loop. Instead, just execute the function a "sufficient" number of
|
|
// times before the timed loop to ensure the function is optimized just once.
|
|
if (type === 'multicharsep') {
|
|
for (i = 0; i < n; i += 1)
|
|
querystring.parse(input, '&&&&&&&&&&');
|
|
|
|
bench.start();
|
|
for (i = 0; i < n; i += 1)
|
|
querystring.parse(input, '&&&&&&&&&&');
|
|
bench.end(n);
|
|
} else {
|
|
for (i = 0; i < n; i += 1)
|
|
querystring.parse(input);
|
|
|
|
bench.start();
|
|
for (i = 0; i < n; i += 1)
|
|
querystring.parse(input);
|
|
bench.end(n);
|
|
}
|
|
}
|