mirror of
https://github.com/nodejs/node.git
synced 2025-05-18 04:06:21 +00:00
fc9d44c8ac
On Windows it might take too long for the parent to start the communication with a child process, so by the time the parent starts its own timer, the child process might have already completed running, and the parent in those tests won't have a chance to terminate these child processes after the timeout. To address this issue, raise the time for which the child is supposed to run to make sure that the parent starts its own timer before the child terminates in the tests. Also, split the test into smaller ones to reduce the overhead. PR-URL: https://github.com/nodejs/node/pull/44390 Refs: https://github.com/nodejs/reliability/issues/356 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
46 lines
1.2 KiB
JavaScript
46 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('assert');
|
|
const common = require('./');
|
|
|
|
// Workaround for Windows Server 2008R2
|
|
// When CMD is used to launch a process and CMD is killed too quickly, the
|
|
// process can stay behind running in suspended state, never completing.
|
|
function cleanupStaleProcess(filename) {
|
|
if (!common.isWindows) {
|
|
return;
|
|
}
|
|
process.once('beforeExit', () => {
|
|
const basename = filename.replace(/.*[/\\]/g, '');
|
|
require('child_process')
|
|
.execFileSync(`${process.env.SystemRoot}\\System32\\wbem\\WMIC.exe`, [
|
|
'process',
|
|
'where',
|
|
`commandline like '%${basename}%child'`,
|
|
'delete',
|
|
'/nointeractive',
|
|
]);
|
|
});
|
|
}
|
|
|
|
// This should keep the child process running long enough to expire
|
|
// the timeout.
|
|
const kExpiringChildRunTime = common.platformTimeout(20 * 1000);
|
|
const kExpiringParentTimer = 1;
|
|
assert(kExpiringChildRunTime > kExpiringParentTimer);
|
|
|
|
function logAfterTime(time) {
|
|
setTimeout(() => {
|
|
// The following console statements are part of the test.
|
|
console.log('child stdout');
|
|
console.error('child stderr');
|
|
}, time);
|
|
}
|
|
|
|
module.exports = {
|
|
cleanupStaleProcess,
|
|
logAfterTime,
|
|
kExpiringChildRunTime,
|
|
kExpiringParentTimer
|
|
};
|