mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 09:44:08 +00:00
f9dd34d301
PR-URL: https://github.com/iojs/io.js/pull/1539 Fixes: https://github.com/iojs/io.js/issues/1253 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
40 lines
1.1 KiB
JavaScript
40 lines
1.1 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag use of parseInt without a radix argument
|
|
* @author James Allardice
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
|
|
return {
|
|
"CallExpression": function(node) {
|
|
|
|
var radix;
|
|
|
|
if (node.callee.name === "parseInt") {
|
|
|
|
if (node.arguments.length < 2) {
|
|
context.report(node, "Missing radix parameter.");
|
|
} else {
|
|
|
|
radix = node.arguments[1];
|
|
|
|
// don't allow non-numeric literals or undefined
|
|
if ((radix.type === "Literal" && typeof radix.value !== "number") ||
|
|
(radix.type === "Identifier" && radix.name === "undefined")
|
|
) {
|
|
context.report(node, "Invalid radix parameter.");
|
|
}
|
|
}
|
|
|
|
}
|
|
}
|
|
};
|
|
|
|
};
|