mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 00:19:36 +00:00
f9dd34d301
PR-URL: https://github.com/iojs/io.js/pull/1539 Fixes: https://github.com/iojs/io.js/issues/1253 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
41 lines
952 B
JavaScript
41 lines
952 B
JavaScript
/**
|
|
* @fileoverview Rule to flag assignment of the exception parameter
|
|
* @author Stephen Murray <spmurrayzzz>
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
|
|
var catchStack = [];
|
|
|
|
return {
|
|
|
|
"CatchClause": function(node) {
|
|
catchStack.push(node.param.name);
|
|
},
|
|
|
|
"CatchClause:exit": function() {
|
|
catchStack.pop();
|
|
},
|
|
|
|
"AssignmentExpression": function(node) {
|
|
|
|
if (catchStack.length > 0) {
|
|
|
|
var exceptionName = catchStack[catchStack.length - 1];
|
|
|
|
if (node.left.name && node.left.name === exceptionName) {
|
|
context.report(node, "Do not assign to the exception parameter.");
|
|
}
|
|
}
|
|
}
|
|
|
|
};
|
|
|
|
};
|