mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 02:54:19 +00:00
f9dd34d301
PR-URL: https://github.com/iojs/io.js/pull/1539 Fixes: https://github.com/iojs/io.js/issues/1253 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
72 lines
2.3 KiB
JavaScript
72 lines
2.3 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag use constant conditions
|
|
* @author Christian Schulz <http://rndm.de>
|
|
* @copyright 2014 Christian Schulz. All rights reserved.
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Checks if a node has a constant truthiness value.
|
|
* @param {ASTNode} node The AST node to check.
|
|
* @returns {Bool} true when node's truthiness is constant
|
|
* @private
|
|
*/
|
|
function isConstant(node) {
|
|
switch (node.type) {
|
|
case "Literal":
|
|
case "ArrowFunctionExpression":
|
|
case "FunctionExpression":
|
|
case "ObjectExpression":
|
|
case "ArrayExpression":
|
|
return true;
|
|
case "UnaryExpression":
|
|
return isConstant(node.argument);
|
|
case "BinaryExpression":
|
|
case "LogicalExpression":
|
|
return isConstant(node.left) && isConstant(node.right);
|
|
case "AssignmentExpression":
|
|
return (node.operator === "=") && isConstant(node.right);
|
|
case "SequenceExpression":
|
|
return isConstant(node.expressions[node.expressions.length - 1]);
|
|
// no default
|
|
}
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Reports when the given node contains a constant condition.
|
|
* @param {ASTNode} node The AST node to check.
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function checkConstantCondition(node) {
|
|
if (node.test && isConstant(node.test)) {
|
|
context.report(node, "Unexpected constant condition.");
|
|
}
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
"ConditionalExpression": checkConstantCondition,
|
|
"IfStatement": checkConstantCondition,
|
|
"WhileStatement": checkConstantCondition,
|
|
"DoWhileStatement": checkConstantCondition,
|
|
"ForStatement": checkConstantCondition
|
|
};
|
|
|
|
};
|