mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 00:19:36 +00:00
f9dd34d301
PR-URL: https://github.com/iojs/io.js/pull/1539 Fixes: https://github.com/iojs/io.js/issues/1253 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
31 lines
920 B
JavaScript
31 lines
920 B
JavaScript
/**
|
|
* @fileoverview Rule to flag for-in loops without if statements inside
|
|
* @author Nicholas C. Zakas
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
|
|
return {
|
|
|
|
"ForInStatement": function(node) {
|
|
|
|
/*
|
|
* If the for-in statement has {}, then the real body is the body
|
|
* of the BlockStatement. Otherwise, just use body as provided.
|
|
*/
|
|
var body = node.body.type === "BlockStatement" ? node.body.body[0] : node.body;
|
|
|
|
if (body && body.type !== "IfStatement") {
|
|
context.report(node, "The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.");
|
|
}
|
|
}
|
|
};
|
|
|
|
};
|