node/test/parallel/test-http-server-close-idle.js
Santiago Gimeno f8f2772572
test: fix flaky test-https-server-close- tests
Don't initiate the second connection until the first has been
established.

Refs: https://github.com/nodejs/reliability/issues/289

PR-URL: https://github.com/nodejs/node/pull/43216
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-06-19 17:19:52 +01:00

72 lines
1.8 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const { createServer } = require('http');
const { connect } = require('net');
let connections = 0;
const server = createServer(common.mustCall(function(req, res) {
res.writeHead(200, { Connection: 'keep-alive' });
res.end();
}), {
headersTimeout: 0,
keepAliveTimeout: 0,
requestTimeout: common.platformTimeout(60000),
});
server.on('connection', function() {
connections++;
});
server.listen(0, function() {
const port = server.address().port;
let client1Closed = false;
let client2Closed = false;
// Create a first request but never finish it
const client1 = connect(port);
client1.on('connect', common.mustCall(() => {
// Create a second request, let it finish but leave the connection opened using HTTP keep-alive
const client2 = connect(port);
let response = '';
client2.on('data', common.mustCall((chunk) => {
response += chunk.toString('utf-8');
if (response.endsWith('0\r\n\r\n')) {
assert(response.startsWith('HTTP/1.1 200 OK\r\nConnection: keep-alive'));
assert.strictEqual(connections, 2);
server.closeIdleConnections();
server.close(common.mustCall());
// Check that only the idle connection got closed
setTimeout(common.mustCall(() => {
assert(!client1Closed);
assert(client2Closed);
server.closeAllConnections();
server.close(common.mustCall());
}), common.platformTimeout(500)).unref();
}
}));
client2.on('close', common.mustCall(() => {
client2Closed = true;
}));
client2.write('GET / HTTP/1.1\r\n\r\n');
}));
client1.on('close', common.mustCall(() => {
client1Closed = true;
}));
client1.on('error', () => {});
client1.write('GET / HTTP/1.1');
});