mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 17:57:53 +00:00
da886d9a4c
- Use assert to check mode in the Zlib constructor since it should only be passed by us. - Introduce checkRangesOrGetDefault() and checkFiniteNumber() to simplify type and range checking for numeric arguments - Instead of `ERR_INVALID_OPT_VALUE`, throw `ERR_OUT_OF_RANGE` and `ERR_INVALID_ARG_TYPE` with descriptions of the expected ranges or types to make the errors more user-friendly. - Add message tests for the changed errors PR-URL: https://github.com/nodejs/node/pull/18675 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
48 lines
1.2 KiB
JavaScript
48 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const zlib = require('zlib');
|
|
|
|
zlib.createGzip({ flush: zlib.constants.Z_SYNC_FLUSH });
|
|
|
|
common.expectsError(
|
|
() => zlib.createGzip({ flush: 'foobar' }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "options.flush" property must be of type number. ' +
|
|
'Received type string'
|
|
}
|
|
);
|
|
|
|
common.expectsError(
|
|
() => zlib.createGzip({ flush: 10000 }),
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
type: RangeError,
|
|
message: 'The value of "options.flush" is out of range. It must ' +
|
|
'be >= 0 and <= 5. Received 10000'
|
|
}
|
|
);
|
|
|
|
zlib.createGzip({ finishFlush: zlib.constants.Z_SYNC_FLUSH });
|
|
|
|
common.expectsError(
|
|
() => zlib.createGzip({ finishFlush: 'foobar' }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "options.finishFlush" property must be of type number. ' +
|
|
'Received type string'
|
|
}
|
|
);
|
|
|
|
common.expectsError(
|
|
() => zlib.createGzip({ finishFlush: 10000 }),
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
type: RangeError,
|
|
message: 'The value of "options.finishFlush" is out of range. It must ' +
|
|
'be >= 0 and <= 5. Received 10000'
|
|
}
|
|
);
|