mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 17:57:53 +00:00
3c29adb84f
* exit naturally, don't use process.exit() * ensure callbacks are actually called PR-URL: https://github.com/nodejs/node/pull/18792 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
34 lines
977 B
JavaScript
34 lines
977 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const tls = require('tls');
|
|
const assert = require('assert');
|
|
|
|
const cert = fixtures.readSync('test_cert.pem');
|
|
const key = fixtures.readSync('test_key.pem');
|
|
|
|
// https://github.com/nodejs/node/issues/1489
|
|
// tls.connect(options) with no options.host should accept a cert with
|
|
// CN:'localhost'
|
|
const server = tls.createServer({
|
|
key,
|
|
cert
|
|
}).listen(0, common.mustCall(function() {
|
|
const socket = tls.connect({
|
|
port: this.address().port,
|
|
ca: cert,
|
|
// No host set here. 'localhost' is the default,
|
|
// but tls.checkServerIdentity() breaks before the fix with:
|
|
// Error: Hostname/IP doesn't match certificate's altnames:
|
|
// "Host: undefined. is not cert's CN: localhost"
|
|
}, common.mustCall(function() {
|
|
assert(socket.authorized);
|
|
socket.destroy();
|
|
server.close();
|
|
}));
|
|
}));
|